README edit to change Apple Silicon install instructions (to fix a break introduced by pytorch 2) #8122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Apple Silcon install instrictions based on issue 8116: NVIDIA#8116 (comment) Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk>
Added comment Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk>
minitu
pushed a commit
to minitu/NeMo
that referenced
this pull request
Jan 19, 2024
…eak introduced by pytorch 2) (NVIDIA#8122) * Update README.rst Changed Apple Silcon install instrictions based on issue 8116: NVIDIA#8116 (comment) Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk> * Update README.rst Added comment Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk> --------- Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk>
|
git clone and cd'ing into NeMo became obsolete when installing from pypi. Imo those commands can be removed? git clone https://github.com/NVIDIA/NeMo
cd NeMoIn my case, I only get v1.21 installed from pypi. With |
|
According to this comment, macOS is not supported by triton at all. |
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
…eak introduced by pytorch 2) (NVIDIA#8122) * Update README.rst Changed Apple Silcon install instrictions based on issue 8116: NVIDIA#8116 (comment) Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk> * Update README.rst Added comment Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk> --------- Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk> Signed-off-by: Sasha Meister <ameister@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…eak introduced by pytorch 2) (NVIDIA#8122) * Update README.rst Changed Apple Silcon install instrictions based on issue 8116: NVIDIA#8116 (comment) Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk> * Update README.rst Added comment Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk> --------- Signed-off-by: Stephen <stephen.mcconnachie@bfi.org.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR aims to correct a small error in the Apple Silcon installation instructions in README, where a triton dependency is problematic due to pytorch 2. The use of
/reinstall.shdoesn't work, so usingpip installinstead. Also added a note about MacBook, to clarify that only asr toolkit is supported.Additional Information