Explicitly track active renderer instead of relying on vid_rtx. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of code assumes the value of vid_rtx also reflects the current renderer. However, it can happen that this is not the case, causing code to rely on this assumption to break (see NVIDIA#198). Address by explicitly storing the currently active renderer and updating that field on renderer initialization/shutdown. Also change any code that used vid_rtx to check the renderer to use that new value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of code assumes the value of vid_rtx also reflects the current renderer.
However, it can happen that this is not the case, causing code to rely on this
assumption to break (see #198).
Address by explicitly storing the currently active renderer and updating that
field on renderer initialization/shutdown. Also change any code that used vid_rtx
to check the renderer to use that new value.