Don't special handle RF_FRAMELERP on the client. #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purpose of this flag is unknown. It doesn't seem to do anything useful. Effectively, it just disables entity origin interpolation in CL_AddPacketEntities(), and requires the renderer to do interpolation instead. Use of RF_FRAMELERP also requires old_origin to be always valid. While Q2PRO server guarantees this, other servers may not. RF_FRAMELERP is actually harmful: because lerp_origin is stepped discretely, effects like particle trails look odd on RF_FRAMELERP entities. Also, since Q2PRO renderer only interpolates origin if RF_FRAMELERP is set, interpolation of linked entities with this flag cleared is broken. Simply remove special handling of RF_FRAMELERP from client and renderer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this flag is unknown. It doesn't seem to do anything useful. Effectively, it just disables entity origin interpolation in CL_AddPacketEntities(), and requires the renderer to do interpolation instead. Use of RF_FRAMELERP also requires old_origin to be always valid. While Q2PRO server guarantees this, other servers may not.
RF_FRAMELERP is actually harmful: because lerp_origin is stepped discretely, effects like particle trails look odd on RF_FRAMELERP entities. Also, since Q2PRO renderer only interpolates origin if RF_FRAMELERP is set, interpolation of linked entities with this flag cleared is broken.
Simply remove special handling of RF_FRAMELERP from client and renderer.
Fixes choppy enemy movement in GL renderer, introduced by 5e2a2d3.