Sync with Q2PRO: More filesystem changes #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files from game dir should always override baseq2.
Broken by 02f8ab66.
When changing game dir, default.cfg needs to be executed to update ‘newgame’ alias and such, so that single player menu works. Rather than skipping default.cfg and config.cfg if baseq2/autoexec.cfg exists, exec baseq2/autoexec.cfg after default.cfg and config.cfg.
Empty string means no game dir is set. Resetting to default is wrong if DEFGAME is not empty.
Doing so could lead to infinite config exec loops.
Apparently, mkdir("c:") is legal, but mkdir("c:/") gives EACCESS on
Windows. So if path has double slashes after drive part, such as
"c://foo/bar" FS_CreatePath() would attempt to mkdir("c:/") and fail.
Change it to always skip the drive part (and leading slashes).
Fixes NVIDIA#316.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More upstream filesystem changes (mostly related to game dir handling).