Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine the functionality of the convert_to_tensors decorator and the dtypes constraint. #420

Merged
merged 12 commits into from
Dec 10, 2024
Merged

Combine the functionality of the convert_to_tensors decorator and the dtypes constraint. #420

merged 12 commits into from
Dec 10, 2024

Conversation

slyubomirsky
Copy link
Collaborator

@slyubomirsky slyubomirsky commented Dec 3, 2024 •
edited
Loading

Address #408. Since all of the functions that used the convert_to_tensors decorator also applied a dtypes constraint, the approach here is to simply include the option to do conversions in the dtypes constraint and rename the decorator to interface, to indicate a more general function.

@slyubomirsky slyubomirsky force-pushed the combine-convert-tensors-and-dtypes-constraint branch from a388a6f to f046a23 Compare December 5, 2024 03:35
@slyubomirsky
Combine the functionality of the convert_to_tensors decorator and the…
42eedc1 
… dtypes constraint
@slyubomirsky
Formatting in docs
5fe7ba9
@slyubomirsky
Restore WAR for dealing with constraints tests; the original reason s…
ce1bbf0 
…till applies
@slyubomirsky
Skip adding test cases when no constraints are given
e1c318b
@slyubomirsky
Rename constraints.dtypes to constraints.interface and adjust documen…
156b9d8 
…tation accordingly. Simplify signature.
@slyubomirsky
Only call merge_function_arguments once
463c76d
@slyubomirsky
Add unit tests for stack depth of build
6eaa660
@slyubomirsky
Bugfix: There are edge cases in slice where the different slice param…
9458c38 
…s do have different stack depths
@slyubomirsky
Add unit tests for get_arg_candidate_column_offsets
867374e
@slyubomirsky
Use the correct frame index
5290f3c
@slyubomirsky
Rename constraints to wrappers
88cc0a8
@slyubomirsky
Improve test case for slice of an inline output
efd985a
@slyubomirsky slyubomirsky force-pushed the combine-convert-tensors-and-dtypes-constraint branch from e80787a to efd985a Compare December 10, 2024 08:03
@slyubomirsky slyubomirsky merged commit b82c737 into main Dec 10, 2024
1 check passed
@slyubomirsky slyubomirsky deleted the combine-convert-tensors-and-dtypes-constraint branch December 10, 2024 09:08
@pranavm-nvidia pranavm-nvidia mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavm-nvidia pranavm-nvidia pranavm-nvidia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slyubomirsky @pranavm-nvidia