Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal changes #437

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Move internal changes #437

merged 1 commit into from
Dec 11, 2024

Conversation

shelkesagar29
Copy link
Collaborator

@shelkesagar29 shelkesagar29 commented Dec 11, 2024

This PR moves the following internal commits to OSS,

Validate any stride for empty tensors

Empty tensors can have a variety of strides which are all equally
meaningless. The updated validation check allows any stride if the
tensor has a dimension of size zero.

Exporting APIs for StableHlo PassManager and TRT Executable

This changes breaks compiler.compiler_stablehlo_to_executable into two separate APIs in such a way:
exe = compiler.compiler_stablehlo_to_executable(client, module.operation, opts)

is changed to

pipeline = compiler.StableHloPipeline(client, opts)
exe = compiler.getExecutable(pipeline, module.operation)

This PR moves the following internal commits to OSS,

**Validate any stride for empty tensors**

Empty tensors can have a variety of strides which are all equally
meaningless. The updated validation check allows any stride if the
tensor has a dimension of size zero.

** Exporting APIs for StableHlo PassManager and TRT Executable**

This changes breaks compiler.compiler_stablehlo_to_executable into two separate APIs in such a way:
exe = compiler.compiler_stablehlo_to_executable(client, module.operation, opts)

is changed to

pipeline = compiler.StableHloPipeline(client, opts)
exe = compiler.getExecutable(pipeline, module.operation)

GitOrigin-RevId: 169b47d9d5749a3ae2fd003369d1e6f0a625c97f
Copy link
Collaborator

@christopherbate christopherbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shelkesagar29 shelkesagar29 merged commit f8d4fe5 into main Dec 11, 2024
1 check passed
@shelkesagar29 shelkesagar29 deleted the move_internal_changes branch December 11, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants