TensorRT 7.1 Open Source Release #654
Merged
+43,449
−6,642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 33 alerts and fixes 1 when merging 7455abc2383c83ca9725eeba9a7f1af7dcaec602 into 2b8863d - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Rajeev Rao <rajeevrao@nvidia.com>
kevinch-nv
approved these changes
Jul 1, 2020
|
This pull request introduces 33 alerts and fixes 1 when merging 805810b into 2b8863d - view on LGTM.com new alerts:
fixed alerts:
|
rmccorm4
reviewed
Jul 1, 2020
|
|
||
| * Code formatting tools | ||
| * [Clang-format](https://clang.llvm.org/docs/ClangFormat.html) | ||
| * [Git-clang-format](https://github.com/llvm-mirror/clang/blob/master/tools/clang-format/git-clang-format) | ||
|
|
||
| * Required PyPI packages for Demos | ||
| * [Tensorflow-gpu](https://pypi.org/project/tensorflow/1.14.0/) == 1.15.0 |
There was a problem hiding this comment.
1.14.0 vs 1.15.0 conflict
Comment on lines
+5
to
+8
| ## vNext | ||
|
|
||
| ### Fixed | ||
| - `fold_constants()` will no longer fail if there is nothing to fold in the graph |
There was a problem hiding this comment.
Should vNext be a specific version here?
|
|
||
|
|
||
| NOTE: Along with the TensorRT OSS components, the following source packages will also be downloaded, and they are not required to be installed on the system. | ||
|
|
||
| - [ONNX-TensorRT](https://github.com/onnx/onnx-tensorrt) v7.0 | ||
| - [ONNX-TensorRT](https://github.com/onnx/onnx-tensorrt) v7.1 | ||
| - [CUB](http://nvlabs.github.io/cub/) v1.8.0 | ||
| - [Protobuf](https://github.com/protocolbuffers/protobuf.git) v3.8.x |
There was a problem hiding this comment.
Pretty sure this should protobuf version is v3.0.0 per #378 and https://github.com/NVIDIA/TensorRT/pull/654/files#diff-af3b638bc2a3e6c650974192a53c7291R85
|
This pull request introduces 33 alerts and fixes 1 when merging 805810b into 2b8863d - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rajeev Rao rajeevrao@nvidia.com