Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Upgrade to Pylint 3.3.1 in lint test #1256

Closed
wants to merge 8 commits into from

Conversation

timmoon10
Copy link
Collaborator

Description

We have experienced failures in the linter since Pylint 2.13.5 doesn't support Python 3.12 (see pylint-dev/astroid#2201, pylint-dev/pylint#8782). This can be fixed by upgrading to Pylint 3.3.1, but that also introduces several new checks. This PR fixes those issues, with no substantial functional changes.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor
  • Testing

Changes

  • Upgrade to Pylint 3.3.1 in PyTorch lint test
  • Fix linter warnings from Pylint 3.3.1

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added bug Something isn't working testing Improvements to tests or testing infrastructure labels Oct 16, 2024
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10 timmoon10 mentioned this pull request Oct 16, 2024
13 tasks
@ksivaman
Copy link
Member

Duplicates #1257

@ksivaman ksivaman closed this Oct 16, 2024
@timmoon10 timmoon10 deleted the upgrade-pylint-3.3.1 branch October 16, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Improvements to tests or testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants