Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 574 ptx #663

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Backport 574 ptx #663

merged 2 commits into from
Nov 8, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Nov 6, 2023

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@miscco miscco requested review from a team as code owners November 6, 2023 18:46
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 6, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@miscco miscco force-pushed the backport_574_ptx branch 2 times, most recently from 5114709 to e1bb33c Compare November 6, 2023 18:49
@jrhemstad
Copy link
Collaborator

/ok to test

wmaxey
wmaxey requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@wmaxey wmaxey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

___CUDA_VPTX mixup needs to be fixed before merging. I'll make a PR that should be merged first and then appended to this PR.

@jrhemstad jrhemstad mentioned this pull request Nov 6, 2023
Closed
@jrhemstad
Copy link
Collaborator

/ok to test

@jrhemstad jrhemstad mentioned this pull request Nov 7, 2023
Merged
2 tasks
@wmaxey @miscco
fixup ___CUDA_VPTX -> _CUDA_VPTX (NVIDIA#664)
94ac300 
* fixup `___CUDA_VPTX` -> `_CUDA_VPTX`

* Fix warning for unused variable in branches that are constexpr disabled.
@jrhemstad
Copy link
Collaborator

/ok to test

@jrhemstad jrhemstad merged commit bb37c94 into NVIDIA:branch/2.3.x Nov 8, 2023
515 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmaxey wmaxey wmaxey approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard was automatically assigned from NVIDIA/cccl-cmake-codeowners

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from NVIDIA/cccl-codeowners

@jarmak-nv jarmak-nv Awaiting requested review from jarmak-nv jarmak-nv was automatically assigned from NVIDIA/cccl-infra-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miscco @jrhemstad @wmaxey @ahendriksen