-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to Use pathlib.Path for Path-Related Variables #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
force-pushed
the
refactor-path
branch
2 times, most recently
from
August 20, 2024 13:16
516254c
to
fcb65d4
Compare
TaekyungHeo
changed the title
Use Path for Path-related Variables
Refactor to use pathlib.Path for path-related variables
Aug 20, 2024
TaekyungHeo
changed the title
Refactor to use pathlib.Path for path-related variables
Refactor to Use pathlib.Path for Path-Related Variables.
Aug 20, 2024
TaekyungHeo
force-pushed
the
refactor-path
branch
2 times, most recently
from
August 20, 2024 13:23
a90a440
to
c5fd63f
Compare
TaekyungHeo
force-pushed
the
refactor-path
branch
2 times, most recently
from
August 20, 2024 19:19
f62b513
to
1917e69
Compare
TaekyungHeo
changed the title
Refactor to Use pathlib.Path for Path-Related Variables.
Refactor to Use pathlib.Path for Path-Related Variables
Aug 20, 2024
TaekyungHeo
force-pushed
the
refactor-path
branch
2 times, most recently
from
August 21, 2024 20:51
71d22c2
to
146d260
Compare
TaekyungHeo
force-pushed
the
refactor-path
branch
from
August 21, 2024 20:52
146d260
to
0273d86
Compare
TaekyungHeo
force-pushed
the
refactor-path
branch
4 times, most recently
from
August 23, 2024 20:27
7263372
to
7e1479b
Compare
TaekyungHeo
force-pushed
the
refactor-path
branch
from
August 23, 2024 20:48
e2ee297
to
7e1479b
Compare
TaekyungHeo
force-pushed
the
refactor-path
branch
from
August 23, 2024 20:49
7e1479b
to
d953ae5
Compare
@TaekyungHeo if possible, let's make this PR independent from others, because this one is easier to accept and merge, otherwise it might be blocked by others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor to use pathlib.Path for path-related variables. @amaslenn let me know that using the Path type is a better practice in Python for path-related variables. This PR replaces str with pathlib.Path for path-related variables.
Test Plan
1. CI
CI passes
2. Ran on a server
Sleep
NCCL tests