Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Cluster Account and gpus_per_node in Command Generation #210

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Add Support for Cluster Account and gpus_per_node in Command Generation #210

merged 4 commits into from
Sep 27, 2024

Conversation

TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented Sep 26, 2024 •
edited
Loading

Summary

Add support for cluster account and gpus_per_node in Slurm command generation

Test Plan

  1. CI passes
  2. Ran it on a real system and observed the expected error message. Did not get a chance to run it to completion because the data directory is not yet available.

@TaekyungHeo TaekyungHeo added bug Something isn't working Oct24 Oct'24 release feature labels Sep 26, 2024
@TaekyungHeo TaekyungHeo marked this pull request as ready for review September 27, 2024 15:36
@TaekyungHeo TaekyungHeo marked this pull request as draft September 27, 2024 15:55
@TaekyungHeo TaekyungHeo marked this pull request as ready for review September 27, 2024 19:31
srivatsankrishnan
srivatsankrishnan approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@srivatsankrishnan srivatsankrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaekyungHeo TaekyungHeo merged commit b305b86 into NVIDIA:main Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srivatsankrishnan srivatsankrishnan srivatsankrishnan approved these changes

@amaslenn amaslenn Awaiting requested review from amaslenn

@artemry-nv artemry-nv Awaiting requested review from artemry-nv

@srinivas212 srinivas212 Awaiting requested review from srinivas212

Assignees
No one assigned
Labels
bug Something isn't working Oct24 Oct'24 release feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaekyungHeo @srivatsankrishnan