Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance job submission error handling with custom exceptions #41

Merged
merged 1 commit into from
May 29, 2024
Merged

Enhance job submission error handling with custom exceptions #41

merged 1 commit into from
May 29, 2024

Conversation

TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented May 28, 2024 •
edited
Loading

Summary

Enhance job submission error handling with custom exceptions

Test Plan

  1. Added unit tests, and they are passing.
  2. Tested on an internal server, and it prints error messages properly.
ERROR: Job Submission Failed
        Test Name: Tests.1
        Message: Failed to retrieve job ID from command output.
        Command: 'sbatch ...'
        stdout: ''
        stderr: 'sbatch: error: Batch job submission failed: Requested node configuration is not available'

@TaekyungHeo TaekyungHeo force-pushed the not-enough-nodes branch 6 times, most recently from 4463a58 to f112a66 Compare May 28, 2024 16:47
@TaekyungHeo TaekyungHeo marked this pull request as draft May 28, 2024 16:48
@TaekyungHeo TaekyungHeo force-pushed the not-enough-nodes branch 2 times, most recently from 12fa39c to dcbfb3a Compare May 28, 2024 17:15
@TaekyungHeo TaekyungHeo marked this pull request as ready for review May 28, 2024 17:17
@TaekyungHeo TaekyungHeo requested a review from amaslenn May 29, 2024 02:33
@TaekyungHeo TaekyungHeo mentioned this pull request May 29, 2024
Closed
@srinivas212 srinivas212 merged commit 503e2d4 into NVIDIA:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivas212 srinivas212 srinivas212 approved these changes

@amaslenn amaslenn Awaiting requested review from amaslenn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaekyungHeo @srinivas212