Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint imports and high level design doc #50

Merged
merged 3 commits into from
May 30, 2024
Merged

Lint imports and high level design doc #50

merged 3 commits into from
May 30, 2024

Conversation

amaslenn
Copy link
Contributor

Summary

  1. Add import linting to make sure _core doesn't depend on any higher-level modules.
  2. Rework TestTemplateStrategy to avoid dependency on SlurmSystem.
  3. Add initial design description.

Test Plan

CI

Additional Notes

@TaekyungHeo
Copy link
Member

TaekyungHeo commented May 30, 2024

Add import linting to make sure _core doesn't depend on any higher-level modules.

I have not used lint-imports before, but it looks like a good idea.

@TaekyungHeo TaekyungHeo merged commit 7c4e526 into main May 30, 2024
2 checks passed
@TaekyungHeo TaekyungHeo deleted the lint-import branch May 30, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants