Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Optional for correct type annotation in test.py #52

Merged
merged 1 commit into from
May 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cloudai/_core/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def __init__(
cmd_args: Dict[str, str],
extra_env_vars: Dict[str, str],
extra_cmd_args: str,
section_name: Optional[str] = "",
section_name: str = "",
dependencies: Optional[Dict[str, "TestDependency"]] = None,
iterations: Union[int, str] = 1,
nodes: Optional[List[str]] = None,
Expand All @@ -73,7 +73,7 @@ def __init__(
cmd_args (Dict[str, str]): Command-line arguments for the test.
extra_env_vars (Dict[str, str]): Extra environment variables.
extra_cmd_args (str): Extra command-line arguments.
section_name (Optional[str]): The section name of the test in the configuration.
section_name (str): The section name of the test in the configuration.
dependencies (Optional[Dict[str, TestDependency]]): Test dependencies.
iterations (Union[int, str]): Total number of iterations to run the test. Can be an integer or 'infinite'
for endless iterations.
Expand Down