Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve error handling #35

Merged
merged 3 commits into from
Aug 18, 2022
Merged

feat: Improve error handling #35

merged 3 commits into from
Aug 18, 2022

Conversation

bashbunni
Copy link
Contributor

Changes:

  • add error for docker not being installed
  • add error for docker needing to run as root
  • clean up container when canary fails
  • update errors package

@bashbunni
Clean up container when canary fails
55c4cb5 
Signed-off-by: bashbunni <bashbunni.io@gmail.com>
@bashbunni
Add errors for docker issues
1dc267f 
Signed-off-by: bashbunni <bashbunni.io@gmail.com>
@bashbunni
Update errors package
249f88b 
Signed-off-by: bashbunni <bashbunni.io@gmail.com>
@jacobtomlinson jacobtomlinson added the bug Something isn't working label Aug 18, 2022
jacobtomlinson
jacobtomlinson approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo thanks for this @bashbunni!

@jacobtomlinson jacobtomlinson merged commit baa14be into NVIDIA:main Aug 18, 2022
This was referenced Aug 18, 2022
Merged
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashbunni @jacobtomlinson