Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerRunOptions setting #64

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jul 23, 2024

Closes #63

Enables you to specify docker specific run flags to enable more flexible usage with dockerRunOptions.

apiVersion: container-canary.nvidia.com/v1
kind: Validator
name: gpu
description: A GPU example to show you can pass extra flags to Docker
command:
- "sleep"
- "30"
dockerRunOptions:
- "--gpus"
- "all"
checks:
  - name: nvidia-smi
    description: 📦 Can run nvidia-smi
    probe:
      exec:
        command:
          - /usr/bin/nvidia-smi
      initialDelaySeconds: 1

@jacobtomlinson jacobtomlinson requested a review from a team as a code owner July 23, 2024 16:52
Signed-off-by: Jacob Tomlinson <jtomlinson@nvidia.com>
Signed-off-by: Jacob Tomlinson <jtomlinson@nvidia.com>
@jacobtomlinson jacobtomlinson requested a review from jameslamb July 23, 2024 16:56
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

And I really like the --gpus all example, that's a perfect use case for this.

@jacobtomlinson jacobtomlinson merged commit 8f14a3e into NVIDIA:main Jul 23, 2024
7 checks passed
@jacobtomlinson jacobtomlinson deleted the docker-run-options branch July 23, 2024 17:01
@jacobtomlinson jacobtomlinson added the enhancement New feature or request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: allow use of '--network host'
2 participants