Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erase Functionality for dynamic_map #149

Merged
merged 38 commits into from
Dec 21, 2022
Merged

Erase Functionality for dynamic_map #149

merged 38 commits into from
Dec 21, 2022

Conversation

Nicolas-Iskos
Copy link

@Nicolas-Iskos Nicolas-Iskos commented Apr 6, 2022 •
edited
Loading

Erase support added for cuco::dynamic_map, based on cuco::static_map with erase support. See #142. More details to follow soon.

Some benchmark data:

Insert throughput before_after erase support (unique 4B_4B)
Search throughput before_after erase-support (unique 4B_4B)
Erase-all and Insert Throughput (unique 4B_4B)
Erase-none and Search-none Throughput (unique 4B_4B)

@GPUtester
Copy link

Can one of the admins verify this patch?

@Nicolas-Iskos Nicolas-Iskos changed the title WIP: Dynamic map erase WIP: Erase Functionality for Dynamic Map Apr 6, 2022
@Nicolas-Iskos Nicolas-Iskos changed the title WIP: Erase Functionality for Dynamic Map WIP: Erase Functionality for dynamic_map Apr 6, 2022
@PointKernel PointKernel added the type: feature request New feature request label Apr 27, 2022
@Nicolas-Iskos Nicolas-Iskos changed the title WIP: Erase Functionality for dynamic_map Erase Functionality for dynamic_map Apr 30, 2022
@jrhemstad jrhemstad added the Needs Review Awaiting reviews before merging label May 19, 2022
@PointKernel PointKernel added the topic: dynamic_map Issue related to the dynamic_map label May 26, 2022
@PointKernel
Copy link
Member

add to allowlist

@PointKernel
Copy link
Member

PointKernel commented Aug 31, 2022 •
edited
Loading

@Nicolas-Iskos Can you please check the doxygen warnings here (in the check-style CI test) and fix them?

PointKernel
PointKernel requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first round of review.

tests/dynamic_map/erase_test.cu Outdated Show resolved Hide resolved
tests/dynamic_map/erase_test.cu Outdated Show resolved Hide resolved
benchmarks/hash_table/static_map_bench.cu Outdated Show resolved Hide resolved
benchmarks/hash_table/static_map_bench.cu Outdated Show resolved Hide resolved
benchmarks/hash_table/static_map_bench.cu Outdated Show resolved Hide resolved
include/cuco/detail/dynamic_map.inl Outdated Show resolved Hide resolved
include/cuco/detail/dynamic_map.inl Outdated Show resolved Hide resolved
include/cuco/detail/dynamic_map.inl Outdated Show resolved Hide resolved
include/cuco/static_map.cuh Outdated Show resolved Hide resolved
include/cuco/dynamic_map.cuh Outdated Show resolved Hide resolved
sleeepyjack
sleeepyjack reviewed Nov 2, 2022
View reviewed changes
include/cuco/detail/dynamic_map.inl Outdated Show resolved Hide resolved
include/cuco/detail/dynamic_map.inl Outdated Show resolved Hide resolved
include/cuco/dynamic_map.cuh Outdated Show resolved Hide resolved
include/cuco/dynamic_map.cuh Outdated Show resolved Hide resolved
include/cuco/dynamic_map.cuh Outdated Show resolved Hide resolved
include/cuco/detail/dynamic_map.inl Outdated Show resolved Hide resolved
include/cuco/detail/dynamic_map_kernels.cuh Show resolved Hide resolved
include/cuco/detail/dynamic_map_kernels.cuh Outdated Show resolved Hide resolved
include/cuco/detail/dynamic_map_kernels.cuh Outdated Show resolved Hide resolved
include/cuco/detail/static_map_kernels.cuh Show resolved Hide resolved
niskos99 and others added 15 commits November 13, 2022 22:35
@niskos99
code cleanup
6616889
@pre-commit-ci
[pre-commit.ci] auto code formatting
2df247c
@niskos99
switched typedef to using
af7706d
@pre-commit-ci
[pre-commit.ci] auto code formatting
54ae254
@niskos99
responding to PR comments
593fe12
@pre-commit-ci
[pre-commit.ci] auto code formatting
7598e47
@PointKernel
Merge remote-tracking branch 'upstream/dev' into erase
ecd3945
@PointKernel
Add more data types for erase tests
1e6ad99
@PointKernel
Use public murmurhash
9e324fc
@PointKernel
Update static map benchmark: fix runtime stall bug, remove redundant …
bb0e4e9 
…comments and add erase_none and search_none benchmarks
@PointKernel
Update dynamic map benchmark: fix conversion warning, add search_none…
10fd08a 
… and erase_none benchmarks and get rid of sentinel namespace
@PointKernel
Cleanups: get rid of host-side counter vector, remove get_ prefixes a…
788ad29 
…nd async instructions when possible
@PointKernel
Get rid of num_successes getter
c71dd60
@PointKernel
Fix comments
ab4ef0c
@PointKernel
Update tests
d72e403
@ajschmidt8
Copy link
Member

rerun tests

@PointKernel PointKernel merged commit 125e331 into NVIDIA:dev Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleeepyjack sleeepyjack sleeepyjack left review comments

@PointKernel PointKernel PointKernel approved these changes

Assignees
No one assigned
Labels
Needs Review Awaiting reviews before merging topic: dynamic_map Issue related to the dynamic_map type: feature request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Nicolas-Iskos @GPUtester @PointKernel @ajschmidt8 @sleeepyjack @jrhemstad @niskos99