Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move everything to cuda.core.experimental #171

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Move everything to cuda.core.experimental #171

merged 2 commits into from
Oct 15, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Oct 15, 2024 •
edited
Loading

Blocked by / merge after #165.

Close #168.

@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.core Everything related to the cuda.core module labels Oct 15, 2024
@leofang leofang added this to the cuda.core beta 1 milestone Oct 15, 2024
@leofang leofang self-assigned this Oct 15, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang marked this pull request as ready for review October 15, 2024 22:50
@leofang
Copy link
Member Author

leofang commented Oct 15, 2024

This is ready.

vzhurba01
vzhurba01 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@vzhurba01 vzhurba01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leofang
Copy link
Member Author

leofang commented Oct 15, 2024

Thanks, Vlad!

@leofang leofang merged commit bb336aa into NVIDIA:main Oct 15, 2024
@leofang leofang deleted the experimental branch October 15, 2024 23:12
@leofang leofang mentioned this pull request Oct 15, 2024
Merged
@leofang leofang mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhurba01 vzhurba01 vzhurba01 approved these changes

@ksimpson-work ksimpson-work Awaiting requested review from ksimpson-work

Assignees

@leofang leofang

Labels
cuda.core Everything related to the cuda.core module feature New feature or request P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 1
Development

Successfully merging this pull request may close these issues.

Move everything to under the experimental namespace
2 participants
@leofang @vzhurba01