rectify the supported types for ObjectCode and Program #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed on the nvrtc API
ksimpson-work
requested review from
vzhurba01 and
leofang
and removed request for
vzhurba01
This was referenced Nov 7, 2024
leofang
added
enhancement
leofang
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program's supported target_types should be a subset of ObjectCode's. Based on the nvrtc API, the supported target_types should be LTOIR, PTX and CUBIN.
If someone used nvcc to compile some.cu file with the -fatbin flag, they should be able to construct an ObjectCode object from that data. Therefore ObjectCode's supported types should not be limited to Program's target_types.
Also supported by nvrtc is optix. So that could be added as well down the road. This change can remain minimal.
#close 212