Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix density matrix qubit ordering bug #1033

Merged
merged 16 commits into from
Dec 18, 2023
Merged

Fix density matrix qubit ordering bug #1033

merged 16 commits into from
Dec 18, 2023

Conversation

anthony-santana
Copy link
Collaborator

@anthony-santana anthony-santana commented Dec 12, 2023 •
edited
Loading

Description

Fixes a bug on the QPP density matrix backend where the qubit ordering was getting flipped after adding additional qubits mid-circuit.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 12, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@anthony-santana anthony-santana changed the title [DON'T MERGE] density matrix simulator bit ordering Fix density matrix qubit ordering bug Dec 13, 2023
@anthony-santana anthony-santana marked this pull request as ready for review December 13, 2023 18:58
@anthony-santana anthony-santana enabled auto-merge (squash) December 13, 2023 18:59
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Dec 13, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

bmhowe23
bmhowe23 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

runtime/nvqir/qpp/QppDMCircuitSimulator.cpp Outdated Show resolved Hide resolved
@bmhowe23 bmhowe23 added the bug fix To be listed under Bug Fixes in the release notes label Dec 13, 2023
schweitzpgi
schweitzpgi reviewed Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes.

runtime/nvqir/qpp/QppDMCircuitSimulator.cpp Outdated Show resolved Hide resolved
runtime/nvqir/qpp/QppDMCircuitSimulator.cpp Outdated Show resolved Hide resolved
unittests/backends/QPPTester.cpp Outdated Show resolved Hide resolved
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Dec 13, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Dec 13, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
@cuda-quantum-bot
Docs preview for PR #1033.
7666c2f
1tnguyen
1tnguyen approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great👍

@anthony-santana
initial primitive implementation for qpp
7219b14 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
mostly working qpp implementation. the state vector check in integrat…
c4f90cc 
…ion test is failing but as a false flag

Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
finish qpp implementation and testing
56ba4e9 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
initial density matrix implementation (tests failing)
fb2b329 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
finish dm testing, with bug in integration
e2bee98 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
initial repro
cd93637 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
remove other changes
5a4efb5 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
forgot a test
5ab1e8e 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
python repro attempt
92e4d66 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
clean up repros
5ed9de8 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
update test comments
8a03e2d 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
new test case
8e33500 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
push with fix and cleanup
03e363e 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
pr comments and qreg to qvector fix
70a34dd 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
pull out tests to stop interesting bug
ecaefb7 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
missing format
6db6937 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Dec 18, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana anthony-santana merged commit 1f9b964 into NVIDIA:main Dec 18, 2023
107 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@anthony-santana anthony-santana deleted the dm_bug branch March 18, 2024 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi left review comments

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@1tnguyen 1tnguyen 1tnguyen approved these changes

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anthony-santana @schweitzpgi @1tnguyen @bmhowe23 @bettinaheim