Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cmake property to gather dependencies for test #1038

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Use cmake property to gather dependencies for test #1038

merged 4 commits into from
Dec 20, 2023

Conversation

Yaraslaut
Copy link
Contributor

Description

Closes #956

Introduced cmake property CUDAQ_RUNTIME_LIBS to specify required libraries to build tests

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 15, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

CLA Assistant Lite bot All Contributors have signed the CLA.

@Yaraslaut
Copy link
Contributor Author

I have read the Contributor License Agreement and I hereby accept the Terms.

recheck

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Dec 15, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 15, 2023
@cuda-quantum-bot
Docs preview for PR #1038.
e795458
@bmhowe23
Copy link
Collaborator

@Yaraslaut would you mind trying to respond "I have read the Contributor License Agreement and I hereby accept the Terms." in a comment all by itself?

@Yaraslaut
Copy link
Contributor Author

I have read the Contributor License Agreement and I hereby accept the Terms.

cuda-quantum-bot added a commit that referenced this pull request Dec 16, 2023
@cuda-quantum-bot
@Yaraslaut has signed the CLA from Pull Request #1038
ffe469d
schweitzpgi
schweitzpgi approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

@bmhowe23 bmhowe23 enabled auto-merge (squash) December 19, 2023 03:23
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Dec 19, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@cuda-quantum-bot
Docs preview for PR #1038.
ec010c2
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@cuda-quantum-bot
Docs preview for PR #1038.
aad0767
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Dec 19, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 merged commit 10198ac into NVIDIA:main Dec 20, 2023
109 checks passed
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
@cuda-quantum-bot
Docs preview for PR #1038.
157ee28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.

CUDA Quantum runtime libraries should self-register as libraries in a cmake property
4 participants
@Yaraslaut @bmhowe23 @schweitzpgi @bettinaheim