Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of single-term spin_op with kernel_builder::exp_pauli #1071

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Enable use of single-term spin_op with kernel_builder::exp_pauli #1071

merged 4 commits into from
Jan 6, 2024

Conversation

amccaskey
Copy link
Collaborator

Currently, the Pauli word argument for kernel_builder::exp_pauli must be a string. Allow one to pass a single-term spin_op.

Useful for use cases like in #1056

@amccaskey
wip
8c4cf7e 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Enable use of single-term spin_op with exp_pauli with kernel_builder
51a42c3 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 5, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

1tnguyen
1tnguyen approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

amccaskey and others added 2 commits January 5, 2024 18:25
@amccaskey @1tnguyen
Update runtime/cudaq/builder/kernel_builder.h
737403b 
Co-authored-by: Thien Nguyen <58006629+1tnguyen@users.noreply.github.com>
@amccaskey
Merge branch 'main' into pyExpPauliSpinOp
6346986
@amccaskey
Copy link
Collaborator Author

amccaskey commented Jan 5, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) January 5, 2024 23:26
@amccaskey amccaskey merged commit 93e06d7 into NVIDIA:main Jan 6, 2024
108 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Jan 22, 2024
@amccaskey amccaskey deleted the pyExpPauliSpinOp branch February 29, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

Assignees
No one assigned
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amccaskey @1tnguyen @bettinaheim