Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for OQC Toshiko machine #1195

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Conversation

owen-oqc
Copy link
Contributor

@owen-oqc owen-oqc commented Feb 8, 2024

Description

The current rest helper defaults to the OQC 8 qubit Lucy device. We now want to support 2 devices on the platform including the 32Q Toshiko coaxmon based super conducting qpu.

Copy link

copy-pr-bot bot commented Feb 8, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@owen-oqc owen-oqc force-pushed the oqc-target-improvements branch 2 times, most recently from 28d0c6e to 8b144a3 Compare February 12, 2024 16:58
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Feb 12, 2024

/ok to test

Command Bot: Processing...

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @owen-oqc - thanks for the changes! If you apply the additional changes from here, it should fix the CI issues. You can download the 3 patch files into your local repo and then run the following:

$ git am 000*.patch

The main issue was just getting --emulate option to keep Lucy as the default machine, and the rest of the suggested changes are simple formatting/spelling updates required by our CI.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Feb 13, 2024

/ok to test

Command Bot: Processing...

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bmhowe23
Copy link
Collaborator

@owen-oqc - I cannot merge main into your branch, so will you please do that? Hopefully we can get it merged after it is up to date with the base branch.

@owen-oqc
Copy link
Contributor Author

@owen-oqc - I cannot merge main into your branch, so will you please do that? Hopefully we can get it merged after it is up to date with the base branch.

Done

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Feb 14, 2024

/ok to test

Command Bot: Processing...

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@bmhowe23 bmhowe23 merged commit 57da7d6 into NVIDIA:main Feb 14, 2024
133 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@bettinaheim bettinaheim added this to the release 0.7.0 milestone Mar 8, 2024
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants