-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircuitSimulator Refactor #12
Conversation
CLA Assistant Lite bot All Contributors have signed the CLA. |
I have read the Contributor License Agreement and I hereby accept the Terms. |
4757f64
to
e1ede76
Compare
14eb6f4
to
33c5b14
Compare
@boschmitt Could you please review this? |
33c5b14
to
6c51d87
Compare
684da16
to
0772284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the refactoring, it does simplifies the code. However, it seems that the set of changes is orthogonal; They could have been broken into smaller, more focused PRs (might still be worth doing it).
Breaking up the big python test into smaller ones is a great move, but I would still keep similar ones on the same file, specifically leaving all qalloc
tests in the same file.
The fix in the clang-format configuration file is likely to affect the whole code base, it certainly worth creating a separate PR that with the fix and rerun in the entire codebase.
…mulation types Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
0772284
to
ccd73b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this work Alex!
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Add
applyGate
method for subclasses to implement instead of requiring overloads for all gate methods.Introduce gate queue to better support mid-circuit measurement and data persistence to named classical registers.
Introduce unique cached circuit name to support sub-type caching strategies (e.g. cache the optimal contraction path for a given circuit).
Break up the python quake file check tests into separate ones for easier debugging.