Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build from source guide - Python wheels #1220

Merged
merged 29 commits into from
Feb 22, 2024
Merged

Build from source guide - Python wheels #1220

merged 29 commits into from
Feb 22, 2024

Conversation

bettinaheim
Copy link
Collaborator

Since our wheels only cover glibc version 2.28 and up, we've questions about building python wheels from source from people working with older systems. Hence, updating the guide to also include instructions for building Python wheels from scratch.
Also updating the outdated guidance on the repo, and adding a basic test to check side-by-side installation of C++ and Python support works fine outside our Docker image.

@bettinaheim
Copy link
Collaborator Author

bettinaheim commented Feb 13, 2024 •
edited by github-actions bot
Loading

/create_cache

Command Bot: Processing...
The launched workflow can be found here.
Running workflow from branch main. The created cache will be owned by that branch.
Checking out source code from head bettinaheim:python_src (sha: 5388370).

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
c47808a
github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
e506813
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
fcbc245
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
2e6495e
schweitzpgi
schweitzpgi reviewed Feb 14, 2024
View reviewed changes
Building.md Outdated Show resolved Hide resolved
docker/test/installer/linux.Dockerfile Outdated Show resolved Hide resolved
docker/build/assets.Dockerfile Outdated Show resolved Hide resolved
docker/build/assets.Dockerfile Show resolved Hide resolved
docs/sphinx/data_center_install.rst Show resolved Hide resolved
docs/sphinx/data_center_install.rst Show resolved Hide resolved
docs/sphinx/data_center_install.rst Outdated Show resolved Hide resolved
@bettinaheim @schweitzpgi
Update Building.md
9d8c8ce 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
960b6d8
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
a85c22f
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
a5b46d5
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
67e297d
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
ee27b0f
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 19, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
f00d0f8
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 19, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
09e4686
schweitzpgi
schweitzpgi approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving per our conversation.

@bettinaheim
Copy link
Collaborator Author

Pre-approving per our conversation.

Added a sentence to the install guide as discussed.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
@cuda-quantum-bot
Docs preview for PR #1220.
512cf04
@bettinaheim bettinaheim merged commit d09f557 into NVIDIA:main Feb 22, 2024
17 checks passed
@bettinaheim bettinaheim deleted the python_src branch February 22, 2024 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
@bettinaheim bettinaheim added this to the release 0.7.0 milestone Mar 8, 2024
@bettinaheim bettinaheim added the documentation Improvements or additions to documentation label Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

@efratshabtai efratshabtai Awaiting requested review from efratshabtai

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
release 0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bettinaheim @schweitzpgi