Optimize logger implementation #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bypass some processing if the log level means that the message wasn't actually going to be logged.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
approved these changes
Feb 19, 2024
amccaskey
reviewed
Feb 20, 2024
bettinaheim
added
the
release notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bypasses some processing if the current log level prevents the message from actually being logged.
For the most part, this means that we check the log level before calling
fmt::format(). However, note that some log messages form strings outside of thecudaq::infostructs and then pass the result into thecudaq::info()structs. We cannot optimize those out without more invasive code changes, which for the most part, I've left for a future task. The only exception to that was one particularly hot piece of code inruntime/nvqir/CircuitSimulator.h, where I've wrapped it in a newcudaq::details::should_log()function.Testing on Gorby with some UCCSD benchmarks from @marwafar reveals these changes reduce runtime by 17-32%, but as always, YMMV.