Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue caused by docstrings inside Python kernels #1459

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Fix issue caused by docstrings inside Python kernels #1459

merged 3 commits into from
Apr 1, 2024

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Apr 1, 2024 •
edited
Loading

Fixes #1419

@amccaskey
Fix issue NVIDIA#1419 where docstrings were not being ignored
da6ab67 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 1, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
remove old comment
13d1461 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
spell check
f1ab6bc 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 1, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 1, 2024
@cuda-quantum-bot
Docs preview for PR #1459.
6c4568d
khalatepradnya
khalatepradnya approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amccaskey amccaskey merged commit bb9fb29 into NVIDIA:main Apr 1, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 17, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
@bettinaheim bettinaheim changed the title Fix issue #1419 where docstrings were not being ignored Fix issue caused by docstrings inside Python kernels Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@khalatepradnya khalatepradnya khalatepradnya approved these changes

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.7.1
Development

Successfully merging this pull request may close these issues.

[python] Compilation fails if kernel contains block strings in the middle
3 participants
@amccaskey @khalatepradnya @bettinaheim