Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with unknown base on attribute call (throw an error) #1499

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Fix issue with unknown base on attribute call (throw an error) #1499

merged 4 commits into from
Apr 11, 2024

Conversation

amccaskey
Copy link
Collaborator

@amccaskey amccaskey commented Apr 11, 2024 •
edited
Loading

Fixes #1496 - issue with unknown attribute call expression

import cudaq
@cudaq.kernel
def test_state(N: int):
    q = cudaq.qvector(N)
    h(q[0])
    kernel.h(q[0]) # user error
test_state.compile()

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey
Fix issue with unknown base on attribute call (throw an error)
2ed1c6d 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
format
65e8241 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@bmhowe23
Copy link
Collaborator

Fixes #1496, right?

@amccaskey
Copy link
Collaborator Author

Fixes #1496, right?

Yes. I added that to the description

@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 11, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey
add the test
0050312 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
schweitzpgi
schweitzpgi reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bmhowe23
bmhowe23 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks, Alex!

@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 11, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey enabled auto-merge (squash) April 11, 2024 14:48
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
@cuda-quantum-bot
Docs preview for PR #1499.
0f767f7
@amccaskey
fixed a typo in an error message check
c67d354 
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey
Copy link
Collaborator Author

amccaskey commented Apr 11, 2024 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@amccaskey amccaskey merged commit 1d13f08 into NVIDIA:main Apr 11, 2024
125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@bettinaheim bettinaheim added this to the release 0.7.1 milestone Apr 17, 2024
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi left review comments

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.7.1
Development

Successfully merging this pull request may close these issues.

Compiler doesn't raise an error when using kernel.h(q[0])
4 participants
@amccaskey @bmhowe23 @schweitzpgi @bettinaheim