Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the QTX dialect #157

Merged
merged 1 commit into from
May 16, 2023
Merged

Removes the QTX dialect #157

merged 1 commit into from
May 16, 2023

Conversation

boschmitt
Copy link
Collaborator

Description

This PR removes the QTX dialect and related infrastructure. Two translated passes were adapted to work with Quake instead of QTX and the common dialect is almost removed (next PR will finish it).

@boschmitt boschmitt force-pushed the remove-qtx branch 2 times, most recently from 13afabe to 95e84b9 Compare May 12, 2023 16:09
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for helping clean this up, Bruno. Greatly appreciated.

BTW, I'm planning to steal the gist of the Conversion tests in the memtoreg/regtomem PR that's in the pipeline.

include/cudaq/Optimizer/CodeGen/Passes.td Outdated Show resolved Hide resolved
include/cudaq/Optimizer/Transforms/Passes.td Show resolved Hide resolved
include/cudaq/Target/OpenQASM/OpenQASMEmitter.h Outdated Show resolved Hide resolved
lib/Target/IQM/TranslateToIQMJson.cpp Outdated Show resolved Hide resolved
lib/Target/OpenQASM/TranslateToOpenQASM.cpp Outdated Show resolved Hide resolved
lib/Target/OpenQASM/TranslateToOpenQASM.cpp Outdated Show resolved Hide resolved
@boschmitt boschmitt force-pushed the remove-qtx branch 12 times, most recently from abce2f5 to e5d50c1 Compare May 16, 2023 12:49
@boschmitt boschmitt merged commit e92c9dd into NVIDIA:main May 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
@bettinaheim bettinaheim added the breaking change Change breaks backwards compatibility label Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Change breaks backwards compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants