-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize kernel mode for hybrid QNN test case #1572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmhowe23
changed the title
Optimize kernel mode for Hybrid QNN test case
Optimize kernel mode for hybrid QNN test case
Apr 26, 2024
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
force-pushed
the
pr-optimize-hybrid-qnn
branch
from
April 26, 2024 02:17
88f8ccf
to
b90b2dc
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes for potential future modifications to
examples/python/tutorials/hybrid_qnns.ipynb
.Enumerating and looping over all elements in
inspect.stack()
was incredibly slow when running in a Jupyter notebook. (Interestingly enough, the slowness was not apparent when running a Python script with thepython3
command.)Here are some sample timings before the change:
And after the change:
This is a >20x speedup for this test case, which brings the kernel mode in line with the builder mode.