Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python's for-else #1573

Merged
merged 3 commits into from
May 3, 2024
Merged

Add support for python's for-else #1573

merged 3 commits into from
May 3, 2024

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Apr 25, 2024 •
edited by bettinaheim
Loading

Add an else region to cc.loop.
Add builders, verifiers, etc.
Add roundtrip test.
Add lowering of cc.loop to CFG.
Add test for python for-else to cfg conversion.

@schweitzpgi schweitzpgi enabled auto-merge (squash) April 25, 2024 23:17
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
3fca154
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
3ec5652
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
aabe88c
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
c8f5b8c
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
896ea0a
@schweitzpgi
Copy link
Collaborator Author

ping for review

github-actions bot pushed a commit that referenced this pull request May 1, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
dcfb30b
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 2, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
74b08b1
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 2, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
39416e0
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 2, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
77935ee
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 2, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
1b4fa10
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 2, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
2807ab2
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request May 2, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
939ae59
@schweitzpgi
[Core] Add support for python's for-else to cc.loop.
14b08e3 
Add an else region to cc.loop.
Add builders, verifiers, etc.
Add roundtrip test.
Add lowering of cc.loop to CFG.
Add test for python for-else to cfg conversion.
@schweitzpgi
Fix logic bugs in the tests.
a51ab4c
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@cuda-quantum-bot
Docs preview for PR #1573.
5b1ba6b
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@schweitzpgi schweitzpgi merged commit c655c74 into NVIDIA:main May 3, 2024
124 of 125 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label May 6, 2024
@bettinaheim bettinaheim added this to the release 0.8.0 milestone May 6, 2024
@bettinaheim bettinaheim changed the title [Core] Add support for python's for-else to cc.loop. Add support for python's for-else Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anthony-santana anthony-santana anthony-santana approved these changes

@annagrin annagrin Awaiting requested review from annagrin

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen

@amccaskey amccaskey Awaiting requested review from amccaskey

@boschmitt boschmitt Awaiting requested review from boschmitt

@sacpis sacpis Awaiting requested review from sacpis

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

Assignees
No one assigned
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@schweitzpgi @anthony-santana @bettinaheim