-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and include C++ standard library #1603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake issue..." This reverts commit c54b607.
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:22
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bettinaheim
temporarily deployed
to
ghcr-deployment
July 30, 2024 17:25
— with
GitHub Actions
Inactive
bmhowe23
reviewed
Jul 30, 2024
bmhowe23
reviewed
Jul 30, 2024
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
approved these changes
Jul 30, 2024
This reverts commit 2a7f65e.
…n this PR) to make it a separate PR
bettinaheim
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CUDA-Q installer to use the LLVM C++ standard library (libc++) instead of the GNU C++ standard library (libstdc++). The Docker image and Python wheels are built as before.
In most cases, this should not impact any existing code. This is marked as a breaking change because it may require changes in some cases when integrating with third-party libraries. For more information, see the added docs.
RFC: #1819
There are a bunch of edits I needed to make across the board to make this work, including
include(HandleLLVMOptions)
from top-level CMakeLists.txt; This handles options for the LLVM build and should only be included when directly referencing the MLIR or LLVM headers. In particular, this potentially adds C++ compiler and linker flags, that are plain wrong for some projects in the build (e.g. for the CUDA host compiler)Other changes made:
A couple of other comments:
Pipelines: