Segmentation fault during circuit simulation for large number of controlled gates #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a temporary has a constant size, it can be promoted to the entry block. This eliminates any control dependence that may creep in when the temporary, if added inline, may be in a block with control dependence. Leans into LLVM being able to do live range analysis and fuse/eliminate these allocations. Add a new function in the factory to generate the pattern in LLVM-IR dialect. Fixes NVIDIA#1703. Adds regression test.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a temporary has a constant size, it can be promoted to the entry block. This eliminates any control dependence that may creep in when the temporary, if added inline, may be in a block with control dependence. Leans into LLVM being able to do live range analysis and fuse/eliminate these allocations.
Add a new function in the factory to generate the pattern in LLVM-IR dialect.
Fixes #1703. Adds regression test.