Fix bug for missing function declarations #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
reviewed
Jul 11, 2024
This small change copies function declarations from the "old" module to the new module to fix correctness issues. This will never be a problem if the old module is well formed. Dropping them on the floor is a bug because there may be calls to these functions in the selected kernel, and those calls will fail to verify after the declarations are dropped.
schweitzpgi
force-pushed
the
ch-fix.drop.on.floor.bug
branch
from
ff5e1e9
to
ff118f6
Compare
bettinaheim
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change copies function declarations from the "old" module to the new module to fix correctness issues. This will never be a problem if the old module is well formed. Dropping them on the floor is a bug because there may be calls to these functions in the selected kernel, and those calls will fail to verify after the declarations are dropped.