Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message about not synthesizing state pointers #1974

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Add error message about not synthesizing state pointers #1974

merged 6 commits into from
Jul 20, 2024

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Jul 19, 2024 •
edited by bettinaheim
Loading

Description

Error on synthesizing cudaq::state*

For now, we only support cudaq::state* synthesis on local simulators, add error for all other cases (quantum devices or remote simulators)

Towards: #1086

sacpis
sacpis reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request for one change.

@annagrin annagrin requested a review from sacpis July 19, 2024 19:50
sacpis
sacpis approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@sacpis sacpis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  1. Should we add some tests here?
  2. Does trotter_kernel_mode.cpp works with target nvqc now?

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@cuda-quantum-bot
Docs preview for PR #1974.
8c75331
@annagrin
Copy link
Collaborator Author

annagrin commented Jul 19, 2024 •
edited
Loading

@sacpis

  • Should we add some tests here?
  • Does trotter_kernel_mode.cpp works with target nvqc now?
  • Added tests
  • No, this is just adding an error message instead of a segfault:) I am working on actual support now.

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@cuda-quantum-bot
Docs preview for PR #1974.
0fd8a0c
bmhowe23
bmhowe23 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Anna!

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
@cuda-quantum-bot
Docs preview for PR #1974.
97d6135
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jul 20, 2024
@cuda-quantum-bot
Docs preview for PR #1974.
c4a1431
@annagrin annagrin enabled auto-merge (squash) July 20, 2024 02:37
@annagrin annagrin merged commit 2bf1cb6 into NVIDIA:main Jul 20, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Jul 29, 2024
@bettinaheim bettinaheim added this to the release 0.8.0 milestone Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schweitzpgi schweitzpgi schweitzpgi left review comments

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@sacpis sacpis sacpis approved these changes

Assignees
No one assigned
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@annagrin @sacpis @schweitzpgi @bmhowe23 @bettinaheim