Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error_mitigation and sharpen configurations to IonQ backend #470

Merged
merged 30 commits into from
Nov 3, 2023

Conversation

splch
Copy link
Contributor

@splch splch commented Jul 24, 2023

Description

Error Mitigation
The IonQ quantum computation platform provides an error mitigation option, which can be specified in the backend configuration. To enable error mitigation, set the error_mitigation field in the BackendConfig object to a map containing debias: true, as follows:

config["error_mitigation"]["debias"] = true;

Post Example:

"error_mitigation": {
  "debias": true
}

Sharpen
The IonQ quantum computation platform provides a sharpening feature to enhance the computation precision. This feature can be controlled by setting the sharpen field in the BackendConfig object, as follows:

config["sharpen"] = true;

Query Example:

...&sharpen=true

@bettinaheim bettinaheim added this to the release 0.4.1 milestone Sep 25, 2023
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @splch. Should these changes be paired with any updates to ionq.config to activate the changes? In any case, I'll also post a few suggested updates for my review comments below. Let me know if they meet your intentions.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 26, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Sep 26, 2023

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Oct 24, 2023

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Oct 24, 2023

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Oct 31, 2023

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 1, 2023

/ok to test

Command Bot: Processing...

Copy link

github-actions bot commented Nov 1, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 2, 2023

/ok to test

Command Bot: Processing...

Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also update the IonQ section of the documentation (in docs/sphinx/using/hardware.rst) to explain how/when/why the user should use --ionq-debias and --ionq-sharpen. If that's too much trouble, then you could put it in this comment and I could update it after this PR gets merged.

Copy link

github-actions bot commented Nov 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 3, 2023

I merged from main and applied updates based on my review comments. (Hopefully that's ok...we've got code cutoff for 0.5.0 coming very quickly now, and I figured it would be best to push this along.)

I also ran all the IonQ tests that the nightly integration test would run, and they passed.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 3, 2023

/ok to test

Command Bot: Processing...

Copy link

github-actions bot commented Nov 3, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
@bmhowe23 bmhowe23 enabled auto-merge (squash) November 3, 2023 21:01
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 3, 2023

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 merged commit daa60b3 into NVIDIA:main Nov 3, 2023
105 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Nov 15, 2023
@bettinaheim bettinaheim changed the title adds error_mitigation and sharpen configs Add error_mitigation and sharpen configurations to IonQ backend Nov 15, 2023
@splch splch deleted the symmetrization branch November 17, 2023 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants