-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable one to progressively build a Kernel with the kernel_builder #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1tnguyen
reviewed
Aug 17, 2023
1tnguyen
reviewed
Aug 17, 2023
1tnguyen
approved these changes
Aug 17, 2023
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
amccaskey
force-pushed
the
progressiveBuilder
branch
from
August 17, 2023 15:09
bc27e65
to
37a205d
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
cuda-quantum-bot
added a commit
that referenced
this pull request
Aug 17, 2023
bettinaheim
added
the
release notes
Changes need to be captured in the release notes
label
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup
kernel_builder
to start the wrappedFuncOp
with aReturnOp
instead of manually adding one at eitherto_quake
orjitCode
, and set the insertion point to right before that terminator.With this change, and smarter caching of the wrapped
ExecutionEngine
, thekernel_builder
can be more flexible and allow progressive building / checking of the internal Quake code.Previously, this would lead to seg-faults or MLIR errors.