Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for IQM backends #562

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Add documentation for IQM backends #562

merged 9 commits into from
Sep 8, 2023

Conversation

kukushechkin
Copy link
Contributor

Description

IQM integration docs. Integration is implemented via #468

@rapids-bot
Copy link

rapids-bot bot commented Aug 17, 2023

Pull requests from external contributors require approval from a NVIDIA organization member with write permissions or greater before CI can begin.

@kukushechkin kukushechkin mentioned this pull request Aug 17, 2023
Merged
@kukushechkin kukushechkin marked this pull request as ready for review August 17, 2023 15:52
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 18, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 18, 2023
@cuda-quantum-bot
Docs preview for PR #562.
5c83d47
bmhowe23
bmhowe23 requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason for the CI Docker image failures in the Friday run is that scripts/validate_containers.sh lines 101 and 131 need to be updated to include iqm similar to how ionq and quantinuum are handled.

docs/sphinx/using/hardware.rst Outdated Show resolved Hide resolved
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 21, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 21, 2023
@cuda-quantum-bot
Docs preview for PR #562.
5c919da
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 21, 2023
@cuda-quantum-bot
Docs preview for PR #562.
45c0bf5
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 21, 2023
@cuda-quantum-bot
Docs preview for PR #562.
ab1009a
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Aug 21, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 21, 2023
@cuda-quantum-bot
Docs preview for PR #562.
467b1f5
bmhowe23
bmhowe23 reviewed Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good (and the CI checks pass, which is also good). I think the next step is for me to get an account (in work) and see it working when connecting to a remote backend.

bettinaheim
bettinaheim reviewed Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments - otherwise looks good to me.

docs/sphinx/examples/python/providers/iqm.py Show resolved Hide resolved
docs/sphinx/using/hardware.rst Outdated Show resolved Hide resolved
docs/sphinx/using/hardware.rst Outdated Show resolved Hide resolved
docs/sphinx/using/hardware.rst Show resolved Hide resolved
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 8, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

kukushechkin and others added 3 commits September 8, 2023 15:17
@kukushechkin @bettinaheim
Update docs/sphinx/using/hardware.rst
dcf444c 
Co-authored-by: Bettina Heim <heimb@outlook.com>
@kukushechkin @bettinaheim
Update docs/sphinx/using/hardware.rst
2133428 
Co-authored-by: Bettina Heim <heimb@outlook.com>
@kukushechkin
update example Adonis url to demo.qc.iqm.fi
5923689
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Sep 8, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

bmhowe23
bmhowe23 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM ... thanks!

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
@cuda-quantum-bot
Docs preview for PR #562.
b1c1bdd
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Sep 8, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 enabled auto-merge (squash) September 8, 2023 17:38
@bmhowe23 bmhowe23 merged commit 465c3c4 into NVIDIA:main Sep 8, 2023
101 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
@bmhowe23 bmhowe23 added this to the release 0.5.0 milestone Sep 27, 2023
@bettinaheim bettinaheim changed the title IQM integration docs Add documentation for IQM backends Nov 15, 2023
@bettinaheim bettinaheim added documentation Improvements or additions to documentation no release notes Don't list this PR in the release notes labels Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bettinaheim bettinaheim bettinaheim left review comments

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation no release notes Don't list this PR in the release notes
Projects
None yet
Milestone
release 0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kukushechkin @bmhowe23 @bettinaheim