Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to pass additional command line options #647

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Sep 11, 2023

Add the ability to pass unrecognized command line options from the driver into cudaq-quake. This change will enable addressing a number of bugs relating to features that the driver script isn't enabled for yet.

@schweitzpgi
Copy link
Collaborator Author

Fixes #319, #601, #258

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 12, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@schweitzpgi schweitzpgi force-pushed the ch-driver.options branch 2 times, most recently from e7e16fd to 98a47b4 Compare September 12, 2023 16:53
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@schweitzpgi schweitzpgi enabled auto-merge (squash) September 12, 2023 19:43
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions for your consideration...

include/cudaq/Support/CMakeLists.txt Show resolved Hide resolved
tools/nvqpp/nvq++.in Show resolved Hide resolved
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@schweitzpgi schweitzpgi force-pushed the ch-driver.options branch 2 times, most recently from f1d258a to 3fd9098 Compare September 13, 2023 20:25
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
driver into cudaq-quake. This change will enable addressing a number of
bugs relating to features that the driver script isn't enabled for yet.

Add code to handle target-specific options.

Fix NVIDIA#535: add a version flag for the nvq++ version.

clang-format

Review comments.

Fix infinite loop bug.
@schweitzpgi schweitzpgi merged commit ffb4417 into NVIDIA:main Sep 13, 2023
101 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
@schweitzpgi schweitzpgi deleted the ch-driver.options branch September 13, 2023 22:22
@schweitzpgi schweitzpgi added release notes Changes need to be captured in the release notes breaking change Change breaks backwards compatibility labels Sep 25, 2023
@schweitzpgi schweitzpgi added this to the release 0.4.1 milestone Sep 25, 2023
@bettinaheim bettinaheim changed the title Add the ability to pass unrecognized command line options from the Add the ability to pass additional command line options Sep 27, 2023
@bettinaheim bettinaheim added bug fix To be listed under Bug Fixes in the release notes and removed release notes Changes need to be captured in the release notes breaking change Change breaks backwards compatibility labels Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants