Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #641: QASM export #649

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented Sep 12, 2023

Description

Reimplement topological sorting for OpenQASM export.
Use mlir::CallGraph to build the call graph and do a postorder traversal to emit the functions.

Add more test cases to verify the fix.

#641

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@1tnguyen 1tnguyen merged commit 1baed0e into NVIDIA:main Sep 12, 2023
101 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
@1tnguyen 1tnguyen added this to the release 0.4.1 milestone Sep 25, 2023
@bettinaheim bettinaheim changed the title Reimplement topological sorting for OpenQASM export Fix for issue #641: QASM export Sep 27, 2023
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants