-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance enhancements: observe_n and sample_n broadcast functions #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
added
the
release notes
Changes need to be captured in the release notes
label
Apr 11, 2023
amccaskey
changed the title
Implement observe_n and sample_n broadcast functions in C++ and Python
Performance enhancements: observe_n and sample_n broadcast functions
Apr 11, 2023
amccaskey
requested review from
schweitzpgi,
anthony-santana,
boschmitt and
bettinaheim
April 11, 2023 19:15
amccaskey
force-pushed
the
observe_n
branch
3 times, most recently
from
April 18, 2023 23:57
d7058e1
to
69722e2
Compare
amccaskey
force-pushed
the
observe_n
branch
3 times, most recently
from
April 26, 2023 12:06
9dbce5e
to
bebf005
Compare
boschmitt
reviewed
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks @amccaskey.
I would still want @anthony-santana, which has more familiarity with the python API, to look over.
amccaskey
force-pushed
the
observe_n
branch
2 times, most recently
from
May 1, 2023 14:17
acd36b9
to
0055389
Compare
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
boschmitt
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#62
What's changing
custatevecApplyPauliRotation
for rx,ry,rz (faster than justcustatevecApplyMatrix
)CircuitSimulator
batch mode (keep state memory alive during batch execution, faster than allocation, operation, deallocation over and over again)<psi | H | psi>
, faster for lower qubit counts than sampling the state).observe_n
andsample_n
batch mode execution (faster than iterating over manyobserve
/sample
calls)observe_n
andsample_n
distribute work to all available QPUs on the platform.Runtime Improvements Example
For the following code,
we get the following runtime plots