Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify incomplete processing in OQC server helper #780

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

owen-oqc
Copy link
Contributor

json null previously matched against c++ NULL 0. This allowed the future to terminate and fetch results before processing had finished.

Description

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 16, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Oct 16, 2023

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
@bmhowe23
Copy link
Collaborator

Thanks, @owen-oqc. Do you think this change can explain these two nightly integration test failures?

  1. https://github.com/NVIDIA/cuda-quantum/actions/runs/6346699077
  2. https://github.com/NVIDIA/cuda-quantum/actions/runs/6515196721

The error for those runs looked like this:

[2023-09-29 03:28:12.135] [info] [OQCServerHelp.cpp:267] Null results received; fetching detailed error message here: https://sandbox.qcaas.oqc.app/tasks/225a5665-264f-4730-8400-e1cb10c3fc07/error
terminate called after throwing an instance of 'std::runtime_error'
  what():  OQC backend error message: {"task_error":null}
/__w/_temp/54c4d008-0960-46fa-b317-d7d26c92b688.sh: line 10:  5857 Aborted                 (core dumped) ./a.out

@bmhowe23 bmhowe23 added this to the release 0.5.0 milestone Oct 17, 2023
@bmhowe23 bmhowe23 added the bug fix To be listed under Bug Fixes in the release notes label Oct 17, 2023
@bmhowe23 bmhowe23 changed the title Identify incomplete processing Identify incomplete processing in OQC server helper Oct 17, 2023
@owen-oqc
Copy link
Contributor Author

Thanks, @owen-oqc. Do you think this change can explain these two nightly integration test failures?

  1. https://github.com/NVIDIA/cuda-quantum/actions/runs/6346699077
  2. https://github.com/NVIDIA/cuda-quantum/actions/runs/6515196721

The error for those runs looked like this:

[2023-09-29 03:28:12.135] [info] [OQCServerHelp.cpp:267] Null results received; fetching detailed error message here: https://sandbox.qcaas.oqc.app/tasks/225a5665-264f-4730-8400-e1cb10c3fc07/error
terminate called after throwing an instance of 'std::runtime_error'
  what():  OQC backend error message: {"task_error":null}
/__w/_temp/54c4d008-0960-46fa-b317-d7d26c92b688.sh: line 10:  5857 Aborted                 (core dumped) ./a.out

Yes exactly this

@bmhowe23
Copy link
Collaborator

Yes exactly this

Great! If you merge the latest from main into your branch, we can get this merged after that.

json null previously matched against c++ NULL 0. This allowed the future to terminate and fetch results before processing had finished.
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Oct 17, 2023

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 enabled auto-merge (squash) October 17, 2023 18:57
@bmhowe23 bmhowe23 merged commit b431631 into NVIDIA:main Oct 17, 2023
109 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix To be listed under Bug Fixes in the release notes no release notes Don't list this PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants