Legalization error in basis conversion. #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows legalization to pass in the basis conversion pass. The resulting code may not be executable on the final target, but the assumption is that the QIR profile validation pass will handle those cases.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
Just for clarification/documentation, is this change intended to fix this sequence of commands? [root@docker-desktop build (main)]# nvq++ --target quantinuum --emulate examples/cpp/algorithms/amplitude_estimation.cpp
[root@docker-desktop build (main)]# ./a.out
loc(callsite("amplitude_estimation.cpp":69:15 at "amplitude_estimation.cpp":100:5)): error: failed to legalize operation 'math.fpowi'
terminate called after throwing an instance of 'std::runtime_error'
what(): Remote rest platform Quake lowering failed.
Aborted |
bmhowe23
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows legalization to pass in the basis conversion pass. The resulting code may not be executable on the final target, but the assumption is that the QIR profile validation pass will handle those cases.