Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows for new GHA runners #832

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Oct 27, 2023

Description

The new GHA runners are running a rootless dockerd which requires the following changes:

  • Fix file permissions before using docker cp
  • Use local action to run a command inside a container instead of using the not maintained addnab/docker-run-action action

Working pipeline on new runners: https://github.com/NVIDIA/cuda-quantum/actions/runs/6706737406/job/18223818783?pr=832

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 27, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

CLA Assistant Lite bot All Contributors have signed the CLA.

@jjacobelli
Copy link
Contributor Author

I have read the Contributor License Agreement and I hereby accept the Terms.

@anthony-santana
Copy link
Collaborator

anthony-santana commented Oct 27, 2023

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 28, 2023
@jjacobelli jjacobelli force-pushed the test-new-runners branch 2 times, most recently from b99a5bc to 4ba968d Compare October 30, 2023 17:44
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@jjacobelli jjacobelli force-pushed the test-new-runners branch 2 times, most recently from 41fc8ac to 67075d1 Compare October 31, 2023 12:50
@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli changed the title [DO NOT MERGE] Test new nvidia GHA runners Fix workflows for new GHA runners Oct 31, 2023
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
@jjacobelli jjacobelli marked this pull request as ready for review November 2, 2023 11:50
@jjacobelli jjacobelli marked this pull request as draft November 13, 2023 10:12
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
@bettinaheim bettinaheim marked this pull request as ready for review November 20, 2023 10:19
@bettinaheim bettinaheim merged commit 1208cf2 into NVIDIA:main Nov 20, 2023
105 of 108 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@bettinaheim bettinaheim added the maintenance Work items to update and improve the code base label Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Work items to update and improve the code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants