Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate new qubit-mapping pass for OQC backends #838

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Incorporate new qubit-mapping pass for OQC backends #838

merged 8 commits into from
Nov 2, 2023

Conversation

bmhowe23
Copy link
Collaborator

@bmhowe23 bmhowe23 commented Oct 30, 2023 •
edited by bettinaheim
Loading

Description

This PR contains the necessary changes for the OQC backend to use the new qubit mapping infrastructure. It therefore depends on #610 and #837.

Details

  • Update oqc.config to include new passes
  • Update output ordering logic to account for the swaps that can now be injected into the program during the qubit-mapping pass.
  • Update tests

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 30, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bmhowe23
Copy link
Collaborator Author

bmhowe23 commented Oct 30, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #838.
a385608
@bmhowe23 bmhowe23 mentioned this pull request Oct 30, 2023
Closed
12 tasks
@bmhowe23
Copy link
Collaborator Author

bmhowe23 commented Oct 30, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@cuda-quantum-bot
Docs preview for PR #838.
070c31c
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
@cuda-quantum-bot
Docs preview for PR #838.
531eeb8
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
@cuda-quantum-bot
Docs preview for PR #838.
2455522
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
@cuda-quantum-bot
Docs preview for PR #838.
f380b1e
@bmhowe23 bmhowe23 added the enhancement New feature or request label Nov 1, 2023
@bmhowe23 bmhowe23 added this to the release 0.5.0 milestone Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
@cuda-quantum-bot
Docs preview for PR #838.
bf024c6
@bmhowe23 bmhowe23 marked this pull request as ready for review November 2, 2023 12:58
@bmhowe23 bmhowe23 changed the title [DRAFT] Incorporate new qubit-mapping pass for OQC backends Incorporate new qubit-mapping pass for OQC backends Nov 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
a7a0ddf
@bmhowe23 bmhowe23 mentioned this pull request Nov 2, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
8e9ae38
schweitzpgi
schweitzpgi approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/common/MeasureCounts.cpp Show resolved Hide resolved
runtime/cudaq/platform/default/rest/Executor.cpp Show resolved Hide resolved
runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated Show resolved Hide resolved
runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated Show resolved Hide resolved
runtime/cudaq/platform/default/rest/helpers/oqc/OQCServerHelp.cpp Outdated Show resolved Hide resolved
runtime/cudaq/platform/default/rest/helpers/oqc/oqc.config Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
a6f45da
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
@cuda-quantum-bot
Docs preview for PR #838.
f56ebab
@bmhowe23 bmhowe23 merged commit acbb0cb into NVIDIA:main Nov 2, 2023
105 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@bmhowe23 bmhowe23 deleted the placement_oqc branch November 2, 2023 21:48
@bettinaheim bettinaheim added release notes Changes need to be captured in the release notes and removed enhancement New feature or request labels Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owen-oqc owen-oqc owen-oqc left review comments

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

@anthony-santana anthony-santana Awaiting requested review from anthony-santana

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

Assignees
No one assigned
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bmhowe23 @schweitzpgi @owen-oqc @bettinaheim