-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to validate jupiter notebooks #848
Conversation
CLA Assistant Lite bot All Contributors have signed the CLA. |
I have read the Contributor License Agreement and I hereby accept the Terms. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Thanks, @abhiram6121. Please take a look at https://github.com/NVIDIA/cuda-quantum/actions/runs/6721623115?pr=848 to see a couple of things that our CI is pointing out ... namely the missing license preamble and Python formatting. The license preamble can be copied from other Python files, and that prior link provides a diff that can be used to patch your changes (simply formatting updates). Also, take a look at https://github.com/NVIDIA/cuda-quantum/actions/runs/6722600981/job/18271591978?pr=848. It looks like the new script reported the following:
|
It seems |
@abhiram6121 In docker_images.yml, after the line you added, you need to add another line
This installs nbconvert in the container environment, where the validation script runs. I see in the error above that it actually complained about nbformat, so just I added that to the install line as well. |
Command Bot: Processing... |
@abhiram6121 I used your script to validate the notebooks prior to release. Unfortunately, it looks like running the preprocessor doesn't actually execute the notebook code. I know the docs page of nbconvert suggest to do exactly what you did, and states that it will be executed, but that actually seems to be misleading. The docs were not particularly helpful in finding out what function the command line invokes, so I would have had to look through the code to see how the API has to be called. I instead opted to keep things simpler and went with the following script:
|
Co-authored-by: Bettina Heim <heimb@outlook.com>
@bettinaheim Thanks for the help, have updated accordingly. Please take a look and let me know. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At long last, I've updated out images to contain the necessary tools, and everything looks good. abhiram6121 Thank you very much for this contribution!
Description
Add Jupyter notebooks to CI #726
Checklist: