Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for control qubit negation #86

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Apr 13, 2023

For some unknown reason they cause the sphinx builder script to crash and burn.
Docs changes for PR #81.

@schweitzpgi
Copy link
Collaborator Author

@bettinaheim These documentation changes look fairly mundane, but the bots don't like them. I can't figure out why. Can you take a look?

@bettinaheim
Copy link
Collaborator

@bettinaheim These documentation changes look fairly mundane, but the bots don't like them. I can't figure out why. Can you take a look?

@schweitzpgi Sure. FYI, in case you haven't seen it, if you go to the CI run, you will see a build folder in the artifacts when the docs generation fails. You can click on it to download it. On one hand that folder contains the log files that are mentioned by the docs generation script, and on the other hand, that folder is what contains the build to reproduce the issue locally.

For this PR, the log shows the following sphinx error:

/workspaces/cuda-quantum/docs/sphinx/specification/cudaq/synthesis.rst:61: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 5 supplied.

.. code-block:: cpp
   cudaq::control(kernel{}, {qubit0, !qubit1}, kernel_arg);

You are lacking an empty line after code-block. See also https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-code-block

@schweitzpgi
Copy link
Collaborator Author

@bettinaheim These documentation changes look fairly mundane, but the bots don't like them. I can't figure out why. Can you take a look?

@schweitzpgi Sure. FYI, in case you haven't seen it, if you go to the CI run, you will see a build folder in the artifacts when the docs generation fails. You can click on it to download it. On one hand that folder contains the log files that are mentioned by the docs generation script, and on the other hand, that folder is what contains the build to reproduce the issue locally.

For this PR, the log shows the following sphinx error:

/workspaces/cuda-quantum/docs/sphinx/specification/cudaq/synthesis.rst:61: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 5 supplied.

.. code-block:: cpp
   cudaq::control(kernel{}, {qubit0, !qubit1}, kernel_arg);

You are lacking an empty line after code-block. See also https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-code-block

I did download the zip file, but I found nothing that led me to the problem inside.

@bettinaheim
Copy link
Collaborator

@bettinaheim These documentation changes look fairly mundane, but the bots don't like them. I can't figure out why. Can you take a look?

@schweitzpgi Sure. FYI, in case you haven't seen it, if you go to the CI run, you will see a build folder in the artifacts when the docs generation fails. You can click on it to download it. On one hand that folder contains the log files that are mentioned by the docs generation script, and on the other hand, that folder is what contains the build to reproduce the issue locally.
For this PR, the log shows the following sphinx error:

/workspaces/cuda-quantum/docs/sphinx/specification/cudaq/synthesis.rst:61: ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 5 supplied.

.. code-block:: cpp
   cudaq::control(kernel{}, {qubit0, !qubit1}, kernel_arg);

You are lacking an empty line after code-block. See also https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-code-block

I did download the zip file, but I found nothing that led me to the problem inside.

If you look at the failing step, it tells you

Sphinx exit code: 1
Documentation generation failed with exit code 12.
Check the logs in /workspaces/cuda-quantum/build/logs, and the documentation build output in /workspaces/cuda-quantum/build/docs

The build folder dumped as artifact is this /workspaces/cuda-quantum/build folder. The error message I posted above is in the logs/sphinx_error.txt file.

schweitzpgi and others added 3 commits April 21, 2023 07:30
For some unknown reason they cause the sphinx builder script to crash
and burn.
is bad idea. The link should be relative in case the pages move for any
reason.
@schweitzpgi schweitzpgi merged commit f8bd93a into NVIDIA:main Apr 21, 2023
@schweitzpgi schweitzpgi deleted the ch-why.does.this.fail branch April 21, 2023 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
@bettinaheim bettinaheim changed the title These are the documentation changes for PR #81. Documentation update for control qubit negation Jun 28, 2023
@bettinaheim bettinaheim added the documentation Improvements or additions to documentation label Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants