Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish cuda-quantum images only to NGC, removing pushes to GHCR #900

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

bettinaheim
Copy link
Collaborator

@bettinaheim bettinaheim commented Nov 9, 2023

NGC publishing at this point looks stable, and images can be downloaded without having to create an account.
There is hence no benefit to having them on GitHub since the only thing that changes to get them from NGC instead is the image name.

This PR hence removes the pushes to GHCR such that the image is only pushed to one location. All other images for development will continue to be pushed to GitHub.
Deployment to confirm I didn't break the workflow: https://github.com/NVIDIA/cuda-quantum/actions/runs/6818044714

Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does docker/build/release/cudaq.ext.Dockerfile also need to be updated to change the base_image reference from ghcr.io to nvcr.io?

@bettinaheim
Copy link
Collaborator Author

Does docker/build/release/cudaq.ext.Dockerfile also need to be updated to change the base_image reference from ghcr.io to nvcr.io?

Ah, yes. Well, PR #860 already does that, but it has not been merged yet.

Copy link

github-actions bot commented Nov 9, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@bettinaheim bettinaheim added this to the release 0.5.0 milestone Nov 9, 2023
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the deployment linked to in the description ends up succeeding, this looks good to me.

Copy link

github-actions bot commented Nov 9, 2023

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@bettinaheim bettinaheim merged commit ba3fb4f into main Nov 10, 2023
92 checks passed
@bettinaheim bettinaheim deleted the workflows/publishing branch November 10, 2023 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Nov 15, 2023
@bettinaheim bettinaheim removed the release notes Changes need to be captured in the release notes label Jan 23, 2024
@bettinaheim bettinaheim added the no release notes Don't list this PR in the release notes label Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no release notes Don't list this PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants