-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish cuda-quantum images only to NGC, removing pushes to GHCR #900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does docker/build/release/cudaq.ext.Dockerfile
also need to be updated to change the base_image
reference from ghcr.io to nvcr.io?
Ah, yes. Well, PR #860 already does that, but it has not been merged yet. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the deployment linked to in the description ends up succeeding, this looks good to me.
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
NGC publishing at this point looks stable, and images can be downloaded without having to create an account.
There is hence no benefit to having them on GitHub since the only thing that changes to get them from NGC instead is the image name.
This PR hence removes the pushes to GHCR such that the image is only pushed to one location. All other images for development will continue to be pushed to GitHub.
Deployment to confirm I didn't break the workflow: https://github.com/NVIDIA/cuda-quantum/actions/runs/6818044714