Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support controlled-SWAP's in kernel builder #924

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Support controlled-SWAP's in kernel builder #924

merged 10 commits into from
Dec 18, 2023

Conversation

anthony-santana
Copy link
Collaborator

@anthony-santana anthony-santana commented Nov 14, 2023 •
edited
Loading

Description

Does the glue work for #918 to perform controlled SWAP's from the python and C++ builder.

  • Adds new cudaq::ctrl overloads to the SWAP operation in the C++ builder
  • New overloads support the following as controls: vector of individual qubits, qubit register, variadic arguments containing a mix of qubits/vecs
  • Writes new C++ builder tests for these SWAP functions
  • Binds the controlled SWAP gates to python as cswap
  • New compiler and unit tests for the python controlled SWAP's
  • Adds the python cswap gate to API documentation

Note: Ignore the random formatting changes to unrelated tests

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 14, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@anthony-santana anthony-santana marked this pull request as ready for review November 15, 2023 21:13
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Nov 15, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

1tnguyen
1tnguyen approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@1tnguyen 1tnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Only a couple of nits.

schweitzpgi
schweitzpgi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

python/tests/compiler/ctrl_gates.py Outdated Show resolved Hide resolved
python/tests/unittests/test_kernel_builder.py Outdated Show resolved Hide resolved
runtime/cudaq/builder/kernel_builder.h Show resolved Hide resolved
runtime/cudaq/builder/kernel_builder.h Show resolved Hide resolved
runtime/cudaq/builder/kernel_builder.h Show resolved Hide resolved
@anthony-santana anthony-santana enabled auto-merge (squash) November 16, 2023 17:31
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Nov 16, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana anthony-santana enabled auto-merge (squash) November 16, 2023 17:44
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Nov 16, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

1 similar comment
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Nov 17, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Nov 30, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Dec 11, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Dec 18, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@anthony-santana
upper half of implementation (broken lowering ot qir)
b6ab8be 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
clean up
8d5a29f 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
revert bridge changes
4aa052c 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
finish implementation and tests
f1ff716 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
clean up docstring
0c68d5c 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
fix bugs in tests
69000e2 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
pr comments
b76d8e8 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
fixes to python docstring
5636a07 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
spelling fix
2f0e305 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
ignore cudaq ctrl missing in docs
ac1013f 
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana
Copy link
Collaborator Author

anthony-santana commented Dec 18, 2023 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
@cuda-quantum-bot
Docs preview for PR #924.
ba9ac26
@anthony-santana anthony-santana merged commit 4de1441 into NVIDIA:main Dec 18, 2023
108 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@bettinaheim bettinaheim added the release notes Changes need to be captured in the release notes label Jan 22, 2024
@anthony-santana anthony-santana deleted the c_swap branch March 18, 2024 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1tnguyen 1tnguyen 1tnguyen approved these changes

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

@khalatepradnya khalatepradnya Awaiting requested review from khalatepradnya

Assignees
No one assigned
Labels
release notes Changes need to be captured in the release notes
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anthony-santana @schweitzpgi @1tnguyen @bettinaheim