Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WireType compliance issues with qubit-mapping pass #932

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Fix WireType compliance issues with qubit-mapping pass #932

merged 4 commits into from
Nov 17, 2023

Conversation

bmhowe23
Copy link
Collaborator

  • qubit-mapping pass updated to remove sinks prior to processing and add them back in at the end of the pass
  • Update tests
  • Update CircuitCheck to fix a memory corruption issue due to invalid DenseMap usage

Resolves #928

@bmhowe23
Fix WireType compliance issues with qubit-mapping pass
8b5ae7d 
* qubit-mapping pass updated to remove sinks prior to processing and add
  them back in at the end of the pass
* Update tests
* Update CircuitCheck to fix a memory corruption issue due to invalid
  DenseMap usage
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
@cuda-quantum-bot
Docs preview for PR #932.
e74b72f
schweitzpgi
schweitzpgi reviewed Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks, Ben.

This fixes some of the same tests, I touched in my working branch.

Let me try your changes with my stricter type checking on my end.

lib/Optimizer/Transforms/Mapping.cpp Outdated Show resolved Hide resolved
utils/CircuitCheck/UnitaryBuilder.cpp Show resolved Hide resolved
@bmhowe23 @schweitzpgi
Add location to SinkOp
329eec6 
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
@cuda-quantum-bot
Docs preview for PR #932.
c5b6d36
schweitzpgi
schweitzpgi approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

boschmitt
boschmitt reviewed Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@boschmitt boschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Ben!

utils/CircuitCheck/UnitaryBuilder.cpp Outdated Show resolved Hide resolved
lib/Optimizer/Transforms/Mapping.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
@cuda-quantum-bot
Docs preview for PR #932.
3f5881b
@bmhowe23 bmhowe23 merged commit b6a7ce2 into NVIDIA:main Nov 17, 2023
105 checks passed
@bmhowe23 bmhowe23 deleted the pr-i928-fix-wire-compliance branch November 17, 2023 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boschmitt boschmitt boschmitt left review comments

@schweitzpgi schweitzpgi schweitzpgi approved these changes

Assignees
No one assigned
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.

qubit-mapping has bug threading wire values
4 participants
@bmhowe23 @boschmitt @schweitzpgi @bettinaheim